Skip to content

Term entry sql log10 #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2023
Merged

Term entry sql log10 #2529

merged 9 commits into from
Jul 1, 2023

Conversation

cslylla
Copy link
Contributor

@cslylla cslylla commented Jun 19, 2023 •
edited
Loading

Description

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

CBID2
CBID2 reviewed Jun 20, 2023
View reviewed changes
CBID2
CBID2 suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cslylla! :) I just gave a proofreading recommendation for your entry, so check that out to learn how to improve it. Other than that, you're off to a great start! :)

@caupolicandiaz caupolicandiaz self-assigned this Jun 20, 2023
@caupolicandiaz caupolicandiaz added sql SQL entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jun 20, 2023
caupolicandiaz
caupolicandiaz suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cslylla I've added a couple of comments. Please update the entry, and tag me when you've made the changes. Thanks

@cslylla @CBID2
Update content/sql/concepts/math-functions/terms/log10/log10.md
f055bb9 
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@cslylla
Copy link
Contributor Author

cslylla commented Jun 22, 2023

Hi @cslylla! :) I just gave a proofreading recommendation for your entry, so check that out to learn how to improve it. Other than that, you're off to a great start! :)

Hi @CBID2, thanks for the feedback! I have just approved the suggested change! 😊

cslylla and others added 2 commits June 22, 2023 12:15
@cslylla @caupolicandiaz
Update content/sql/concepts/math-functions/terms/log10/log10.md
bf62a2b 
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
@cslylla @caupolicandiaz
Update content/sql/concepts/math-functions/terms/log10/log10.md
1986e86 
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
@cslylla
Copy link
Contributor Author

cslylla commented Jun 22, 2023

@caupolicandiaz I approved the changes; thank you!

CBID2
CBID2 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caupolicandiaz
caupolicandiaz approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cslylla Looks good

SSwiniarski
SSwiniarski approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cslylla Looks good to merge.

@SSwiniarski SSwiniarski merged commit cf18bdc into Codecademy:main Jul 1, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

👋 @cslylla
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@SSwiniarski SSwiniarski self-assigned this Jul 1, 2023
@SSwiniarski
Copy link
Contributor

@cslylla Congrats on the new entry. Live link here: https://www.codecademy.com/resources/docs/sql/math-functions/log10

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@caupolicandiaz caupolicandiaz caupolicandiaz approved these changes

@SSwiniarski SSwiniarski SSwiniarski approved these changes

@CBID2 CBID2 CBID2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@caupolicandiaz caupolicandiaz

@SSwiniarski SSwiniarski

Labels
new entry New entry or entries sql SQL entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] SQL Math Functions LOG10
4 participants
@cslylla @SSwiniarski @caupolicandiaz @CBID2