Skip to content

Moved bulk of Python: Functions info into separate entries #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 23, 2022

Conversation

Dusch4593
Copy link
Contributor

Description

Per our target keyword efforts.

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@Dusch4593 Dusch4593 added enhancement New feature or request python Python entries new entry New entry or entries keyword Target keywords shortlist labels Apr 15, 2022
@Dusch4593 Dusch4593 changed the title build/refactor: moved bulk of function info into separate entries Moved bulk of Python: Functions info into separate entries Apr 15, 2022
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593, I reviewed this and left a few comments.

Dusch4593 and others added 3 commits April 22, 2022 09:17
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
…onymous-functions.md

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
@Dusch4593
Copy link
Contributor Author

@SSwiniarski I'll incorporate the rest of your suggestions locally and push from there. 😄

@Dusch4593
Copy link
Contributor Author

@SSwiniarski Finished with incorporating your suggestions.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593 LGTM! 👍

Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593 I've added some feedback to this.

Dusch4593 and others added 2 commits April 22, 2022 16:43
Co-authored-by: KTom101 <kyrathompson@me.com>
Co-authored-by: KTom101 <kyrathompson@me.com>
@Dusch4593
Copy link
Contributor Author

Thanks for your feedback @KTom101 🙏🏻 I'm going to implement the rest of it locally and push from there 😃

@Dusch4593
Copy link
Contributor Author

@KTom101 I believe all of the comments/suggestions were addressed?

Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593 Yep, they were. Thanks!

@Dusch4593 Dusch4593 merged commit cddb2a4 into Codecademy:main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keyword Target keywords shortlist new entry New entry or entries python Python entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants