-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Created type error in python errors entry #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkipelago, this looks good for a second review. Thanks for catching this and making a contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkipelago Finished with my review and left you some comments/suggestions 😄
…cs into python-errors
@Dusch4593 I think I was able to fix the things you pointed out. Do I need to do something to request feedback again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkipelago Actually, tagging one of us is all you need to do to let us know you've finished implementing changes to the PR from your side.
Thank you, btw, for implementing all those suggested changes! 😄 I left one more suggestion under errors.md
, but other than that everything LGTM! 👍🏻
@Dusch4593 Thanks for the feedback I corrected the last single-quote and the test passed locally, so hopefully it's all good. Also sorry I did not sync my branch with main before doing the latest correction. In general should I rebase or merge the main changes? |
@sharkipelago, No worries, I merged it when running the checks on your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkipelago Had a couple more comments/suggestions for you 😄
|
||
## Syntax Errors | ||
|
||
Syntax errors, also known as parsing errors, are perhaps the most common kind of complaint you get while you are still learning Python: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax errors, also known as parsing errors, are perhaps the most common kind of complaint you get while you are still learning Python: | |
Syntax errors (also known as parsing errors) occur when a sequence of characters, or tokens, violates the syntax of the Python programming language: |
For the rest of this entry, let's replace all instances of "you" with a neutral, more manual-like tone that doesn't address the reader(s) directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, on line # 15, can we change to make it look similar to the Description
on line # 3. Also, since "errors" is the entry concept, let's place it in bold. Maybe something like this:
"The two types of errors are syntax errors and exceptions."
@Dusch4593 Made the corrections :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkipelago Thank you for the changes! This PR seems ready for merge (I made a small change to the opening sentence in c097860).
Congratulations @sharkipelago, it looks like your changes were merged and are now live in the Python: Errors entry! 🎉 🎊 Quick question, though. Is your GitHub handle linked to your Codecademy profile? Although I see your changes, I don't see your profile credited near the top-right: |
@Dusch4593 Thanks for merging them! I think my github account is linked? I made this PR before linking it though, I'm not sure if that impacts anything. All I had to do was put my handle in the profile right? |
@sharkipelago in addition to that, you may have to log out of your Codecademy account and re-login through your GitHub account. (see CONTRIBUTING.md for more details) After doing so, let's wait for a few minutes and check the Errors entry, again. |
Description
Added information and example of Type Error in Python Errors entry.
Type of Change
Checklist
main
branch.