Skip to content

Add Laravel 5 module files #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2015
Merged

Add Laravel 5 module files #1704

merged 1 commit into from
Feb 10, 2015

Conversation

janhenkgerritsen
Copy link
Contributor

Laravel 5 now has a stable release, so the Laravel 5 module I created and maintained during the Laravel 5 development period can now be added to Codeception. The files in this pull request are the files from https://github.com/janhenkgerritsen/codeception-laravel5.

A sample app similar to the sample app of the Laravel 4 module can be found at https://github.com/janhenkgerritsen/codeception-laravel5-sample. This sample app uses the code in the repository mentioned above. From the sample app I removed the cli test suite, since the tests in that suite only used the Cli module and no functionality specific to the Laravel module was used.

I also added my own personal details as information about the maintainer of the module, is that ok?

@DavertMik
Copy link
Member

👍

@DavertMik
Copy link
Member

That's great! I will add your sample app to .travis.yml of Codeception. Please keep it stable and do not delete it =) Laravel5 will have updates, so this sample app should either be fixed to specific Laravel version or being updated with each release (which is preferable).

I also added my own personal details as information about the maintainer of the module, is that ok?

That's awesome. Finally there is a maintainer for Laravel module )

DavertMik added a commit that referenced this pull request Feb 10, 2015
@DavertMik DavertMik merged commit e9f7a9b into Codeception:2.0 Feb 10, 2015
@DavertMik
Copy link
Member

@janhenkgerritsen
Copy link
Contributor Author

Great! I will not delete the sample app and keep it up to date with the latest releases of Laravel 5.

@janhenkgerritsen janhenkgerritsen deleted the laravel-5-module branch February 10, 2015 08:17
@janhenkgerritsen janhenkgerritsen restored the laravel-5-module branch February 18, 2015 10:13
@janhenkgerritsen janhenkgerritsen deleted the laravel-5-module branch February 18, 2015 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants