2.4 bug 4847

[quantum-x]

PHP's parse_url fails on specific relative URLs.
If the absolute URL is passed, it parses as expected.
PHP Known bug: https://bugs.php.net/bug.php?id=70942
Discussion thread: #4847

Code example:

$I->amOnPage('/units/view/1/page:2');

Behaviour before:

1) AdminDevicesCest: Check i can see a particular device and all its scans
 Test  tests/rServices/AdminDevicesCest.php:checkUnitScans

  [InvalidArgumentException] Invalid URI /units/view/1/page:2

Behavior after:

 I am on page "/units/view/1/page:2"
  [Request Headers] []
  [Page] /units/view/1/page:2
  [Response] 200

Internal Testing

Before patch

Unit Tests (10) ----------------------------------------------------------------------------------------------------------------
✔ UriTest: Url merge (0.00s)
✔ UriTest: Append anchor (0.00s)
✔ UriTest: Merge urls when base uri ends with slash but uri path has no leading slash (0.00s)
✔ UriTest: Append path (0.00s)
✔ UriTest: Merge urls when base uri has no trailing slash and uri path has no leading slash (0.00s)
✔ UriTest: Merging path (0.00s)
✔ UriTest: Append path removes query string and anchor (0.00s)
E UriTest: Merging non parsing path (0.00s)
--------------------------------------------------------------------------------------------------------------------------------

After patch:

Unit Tests (10) ----------------------------------------------------------------------------------------------------------------
✔ UriTest: Merging scheme (0.00s)
✔ UriTest: Append anchor (0.00s)
✔ UriTest: Merge urls when base uri has no trailing slash and uri path has no leading slash (0.00s)
✔ UriTest: Append path (0.00s)
✔ UriTest: Merging path (0.00s)
✔ UriTest: Append empty path (0.00s)
✔ UriTest: Append path removes query string and anchor (0.00s)
✔ UriTest: Url merge (0.00s)
✔ UriTest: Merge urls when base uri ends with slash but uri path has no leading slash (0.00s)
✔ UriTest: Merging non parsing path (0.00s)
--------------------------------------------------------------------------------------------------------------------------------

Best efforts made to ensure the style matches the project - please accept my apologies if it doesn't.

[Naktibalda]

@quantum-x please don't touch master branch, it won't be released until the next year.

[quantum-x]

@Naktibalda .. Sorry, misread the contribution guide.