Improved Phar file loading #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously phar file only loaded code from file named
codecept.phar.This change allows to name the file in any way you like and it will still work.
The change in stub is really simple, it sets alias to
codecept.phar, socodecept.pharis replaced with actual filename inrequire_once 'phar://codecept.phar/vendor/codeception/codeception/app.php';line.The concequence to build process is that both phar files must be built as codecept.phar and PHP does not support building 2 phar files with the same alias, so the build process consists of 3 steps now.
Fixes Codeception/Codeception#5795