Update InnerBrowser.php #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Codeception/Codeception#5977 If you merge this, I'll add the same to [REST module's `sendPOST()`](https://github.com/Codeception/module-rest/blob/master/src/Codeception/Module/REST.php#L446) Questions: * Is the info about `X-Requested-With: XMLHttpRequest` correct? I mean: *How* is the header added when in fact there is no real request, see Codeception/codeception.github.com#334 * Is it possible to add a link in those docblocks? Would be nice for "See `sendAjaxPostRequest()`"
ThomasLandauer
added a commit
to ThomasLandauer/module-rest
that referenced
this pull request
Oct 11, 2020
As promised at Codeception/lib-innerbrowser#15 (comment) :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Codeception/Codeception#5977
If you merge this, I'll add the same to REST module's
sendPOST()Questions:
X-Requested-With: XMLHttpRequestcorrect? I mean: How is the header added when in fact there is no real request, see Update 04-FunctionalTests.md codeception.github.com#334sendAjaxPostRequest()"