Skip to content

PHPUnit 9 compatibility #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2020
Merged

PHPUnit 9 compatibility #8

merged 2 commits into from
Feb 20, 2020

Conversation

Naktibalda
Copy link
Member

  • Fixed 1 broken test
  • proceedSeeInField casts value to string before comparison

@Naktibalda
Fix broken test
fcac62c 
assertContains uses strict comparison in PHPUnit 9
@Naktibalda
proceedSeeInField casts value to string before comparison
ce78d1d 
because assertContains compares strictly in PHPUnit 9
@Naktibalda Naktibalda requested a review from DavertMik February 15, 2020 19:13
@Naktibalda Naktibalda merged commit 2123542 into master Feb 20, 2020
@Naktibalda Naktibalda deleted the phpunit9-fixes branch February 20, 2020 14:48
@Naktibalda Naktibalda mentioned this pull request Feb 20, 2020
Closed
@bloodrain777 bloodrain777 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik Awaiting requested review from DavertMik

1 more reviewer

@ruudboon ruudboon ruudboon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naktibalda @ruudboon