Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for full PHPUnit public API #7

merged 3 commits into from Aug 28, 2020

Support for full PHPUnit public API #7

merged 3 commits into from Aug 28, 2020


Copy link

@ghost ghost commented Aug 15, 2020

Closes #6

  • Support for full PHPUnit public API
  • Optimized readability and maintainability of the code
  • Organized the tests of the asserts in alphabetical order and according to their source
  • Updated all docs about asserts

@Naktibalda Can you please take a look here and there.
It would be great if the changes were merged there to test through the CI here 馃憤 .

Removed unnecessary comments in tests, replaced expectException with expectThrowable
鈥rts.php does and increase maintainability.

Ordered tests according to their source.
@ghost ghost marked this pull request as ready for review August 15, 2020 20:45
@ghost ghost mentioned this pull request Aug 16, 2020
8 tasks
Copy link

Cool, thank you for refactoring this part!
Could you look into failing tests?

Unit Tests (10) --------------------------------------------
PHP Fatal error:  The modifiers of the trait method assertClassHasAttribute() are changed, but this method does not exist. Error in /home/runner/work/module-asserts/module-asserts/src/Codeception/Module/AbstractAsserts.php on line 8

Thank you!

Copy link

ghost commented Aug 16, 2020

@DavertMik The tests are failing because Codeception Module Asserts does not support various asserts from the public phpunit API, including the one that appears in that error, I presented a PR to add a large number of asserts that are not available so far, and since this repository uses that library, the CI server will fail until the changes are made merged first there.

Thank you!

Copy link

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer command in Github Actions fails because it takes too long.
@TavoNiievez Please make this change #8 in your branch.

Copy link

I will fix it myself.

@Naktibalda Naktibalda merged commit 53c64eb into Codeception:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Support for full PHPUnit public API
3 participants