Skip to content

Add no_cleanup_failed option for not cleaning up failed tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2022
Merged

Add no_cleanup_failed option for not cleaning up failed tests #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a2d509
Add no_cleanup_failed option for not cleaning up failed tests
Archanium Jan 6, 2022
da8d583
Update to handle all databases
Archanium Jan 6, 2022
227f5bf
Change name from 'no_cleanup_failed' to 'skip_cleanup_if_failed'
Archanium Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Codeception/Module/Db.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
* * ssl_cipher - list of one or more permissible ciphers to use for SSL encryption (MySQL specific, @see http://php.net/manual/de/ref.pdo-mysql.php#pdo.constants.mysql-attr-cipher)
* * databases - include more database configs and switch between them in tests.
* * initial_queries - list of queries to be executed right after connection to the database has been initiated, i.e. creating the database if it does not exist or preparing the database collation
*
* * skip_cleanup_if_failed - Do not perform the cleanup if the tests failed. If this is used, manual cleanup might be required when re-running
* ## Example
*
* modules:
Expand All @@ -76,6 +76,7 @@
* cleanup: true
* reconnect: true
* waitlock: 10
* skip_cleanup_if_failed: true
* ssl_key: '/path/to/client-key.pem'
* ssl_cert: '/path/to/client-cert.pem'
* ssl_ca: '/path/to/ca-cert.pem'
Expand Down Expand Up @@ -260,6 +261,7 @@ class Db extends Module implements DbInterface
'waitlock' => 0,
'dump' => null,
'populator' => null,
'skip_cleanup_if_failed' => false,
];

/**
Expand Down Expand Up @@ -635,6 +637,15 @@ public function _before(TestInterface $test): void
parent::_before($test);
}

public function _failed(TestInterface $test, $fail)
{
foreach ($this->getDatabases() as $databaseKey => $databaseConfig) {
if ($databaseConfig['skip_cleanup_if_failed'] ?? false) {
$this->insertedRows[$databaseKey] = [];
}
}
}

public function _after(TestInterface $test): void
{
$this->removeInsertedForDatabases();
Expand Down Expand Up @@ -748,7 +759,8 @@ protected function loadDumpUsingDriver(string $databaseKey): void
}

/**
* Inserts an SQL record into a database. This record will be erased after the test.
* Inserts an SQL record into a database. This record will be erased after the test,
* unless you've configured "skip_cleanup_if_failed", and the test fails.
*
* ```php
* <?php
Expand Down