Skip to content

Adjusting Session To Use Session Manager #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2020
Merged

Adjusting Session To Use Session Manager #9

merged 5 commits into from
Aug 26, 2020

Conversation

Fenikkusu
Copy link
Contributor

@Fenikkusu Fenikkusu commented Jul 3, 2020 •
edited
Loading

MemorySession is no longer compatible with the new Adapter setup. This does two things.

  1. Ensure Memory Is Compatible With AbstractAdapter
  2. Adjust Functional Suite To Use Manager With MemorySession

I Believe This Resolves #8

@Fenikkusu Fenikkusu changed the title Adjusting Session To Use Session Manager WIP: Adjusting Session To Use Session Manager Jul 3, 2020
@Fenikkusu Fenikkusu changed the title WIP: Adjusting Session To Use Session Manager Adjusting Session To Use Session Manager Jul 14, 2020
@ruudboon ruudboon merged commit 388e9c7 into Codeception:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruudboon ruudboon ruudboon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MemorySession adapter shouldn't rewrite 'session' service, a manager should
2 participants
@Fenikkusu @ruudboon