Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code standards updated to PHP 7.1 #57

Merged
merged 2 commits into from Jun 3, 2021
Merged

Code standards updated to PHP 7.1 #57

merged 2 commits into from Jun 3, 2021

Conversation

TavoNiievez
Copy link
Member

  • The minimum version of PHP is now 7.1
  • Added strict types
  • Added return types
  • Added some typehints
  • Removed unnecessary qualifiers
  • # as PREG delimiter
  • Fix naming and typos
  • sha1 by default instead of md5.

@TavoNiievez TavoNiievez requested a review from SamMousa May 10, 2021 00:35
@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:41
Naktibalda
Naktibalda requested changes May 18, 2021
View reviewed changes
src/Codeception/Module/REST.php Outdated Show resolved Hide resolved
src/Codeception/Module/REST.php Outdated Show resolved Hide resolved
src/Codeception/Module/REST.php Outdated Show resolved Hide resolved
src/Codeception/Module/REST.php Show resolved Hide resolved
src/Codeception/Module/REST.php Show resolved Hide resolved
src/Codeception/Util/JsonArray.php Outdated Show resolved Hide resolved
src/Codeception/Util/JsonType.php Outdated Show resolved Hide resolved
src/Codeception/Util/JsonType.php Show resolved Hide resolved
src/Codeception/Util/JsonType.php Outdated Show resolved Hide resolved
src/Codeception/Util/JsonType.php Outdated Show resolved Hide resolved
@TavoNiievez TavoNiievez changed the base branch from master to php71 June 3, 2021 11:24
@TavoNiievez TavoNiievez merged commit 2ac5238 into Codeception:php71 Jun 3, 2021
@TavoNiievez TavoNiievez deleted the return-types branch June 3, 2021 11:25
TavoNiievez added a commit that referenced this pull request Nov 5, 2021
@TavoNiievez
Code standards updated to PHP 7.1 (#57)
7908856
TavoNiievez added a commit that referenced this pull request Nov 5, 2021
@TavoNiievez
Code standards updated to PHP 7.1 (#57)
74ca3e6
TavoNiievez added a commit that referenced this pull request Dec 3, 2021
@TavoNiievez
Code standards updated to PHP 7.1 (#57)
2fa8104
@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Naktibalda requested changes

@SamMousa SamMousa Awaiting requested review from SamMousa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TavoNiievez @Naktibalda