Skip to content

Remove outdated php5 logic #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2020
Merged

Remove outdated php5 logic #51

merged 1 commit into from
Nov 22, 2020

Conversation

TavoNiievez
Copy link
Member

Now that the minimum version of php for this module is php 7.0.8 this conditional is never used

@TavoNiievez TavoNiievez added the help wanted Extra attention is needed label Nov 22, 2020
Naktibalda
Naktibalda approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TavoNiievez TavoNiievez marked this pull request as ready for review November 22, 2020 15:04
@TavoNiievez TavoNiievez removed the help wanted Extra attention is needed label Nov 22, 2020
@TavoNiievez TavoNiievez added this to the 1.4.0 milestone Nov 22, 2020
@TavoNiievez TavoNiievez merged commit a80d38d into Codeception:master Nov 22, 2020
@TavoNiievez TavoNiievez deleted the remove_php5_logic branch November 22, 2020 16:41
@TavoNiievez TavoNiievez mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TavoNiievez @Naktibalda