Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 7.0 support #69

Merged
merged 1 commit into from Dec 9, 2020
Merged

Remove PHP 7.0 support #69

merged 1 commit into from Dec 9, 2020

Conversation

TavoNiievez
Copy link
Member

In accordance with what is mentioned in (#39) this module proceeds to progressively remove support for obsolete versions of PHP.

This time 7.0, which has not had any kind of support for 2 years.

@TavoNiievez TavoNiievez added this to the 1.5.0 milestone Dec 9, 2020
@Naktibalda
Copy link
Member

Are you going to remove support for PHP 7.1 in a month as well?

@TavoNiievez
Copy link
Member Author

I would like to clarify that i did not randomly wait a month to send this PR.

What i actually did after removing support for PHP 5.6 with (#39) was remove all the legacy code for PHP 5.6 (#51) and include the PHP 7.0 features where possible (#41).

The intention is to remove support from all unsupported versions of PHP. Which are: PHP 7.0, PHP 7.1 and PHP 7.2. But it is not convenient to remove the support for all of them in a single PR.

First, an unsupported version is removed and then, all the features of the new minimum supported version are added. It has to be done little by little.

What happened is that a more critical task emerged and i had to prioritize it (#54) (#63).

So the answer is no, it won't be in a month, it may be less or it may be more, it depends on how long it takes me to update the code base, but the goal is to only have support for PHP 7.3, PHP 7.4 and PHP 8.0.

@Naktibalda
Copy link
Member

Alright, it makes sense.

It would look better if legacy support was removed and/or features of newer PHP vere used in the same PR.

@TavoNiievez
Copy link
Member Author

It would look better if legacy support was removed and/or features of newer PHP vere used in the same PR.

I thought of that,
So far i was doing it in separate PR because it may be that the functions that i or someone else are adding can benefit from those changes, or that those changes can create conflicts, or behavioral changes in those functions.

But now we have tests on all of them, and i'll try to do it in a single PR with PHP 7.1 and PHP 7.2 and as much as I can, thanks.

@TavoNiievez TavoNiievez merged commit 771bfb9 into Codeception:master Dec 9, 2020
@TavoNiievez TavoNiievez deleted the remove_php_70 branch December 9, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants