Module code adapted for PHPStan #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch works fine for my own symfony project. I plan to do the review within the next days. |
W0rma
reviewed
Aug 2, 2025
Comment on lines
+55
to
+58
| * @param object|class-string $mixed | ||
| * @return EntityRepository<object> |
There was a problem hiding this comment.
Suggested change
| * @param object|class-string $mixed | |
| * @return EntityRepository<object> | |
| * @phpstan-template T of object | |
| * @phpstan-param T|class-string<T> $mixed | |
| * @phpstan-return EntityRepository<T> |
Use generics should make the type hints even more precise. WDYT?
There was a problem hiding this comment.
The truth is... I'm not sure.
I intentionally avoided using @phpstan-- annotations because, although I know it's possible to better express types with templates and generics, I think it makes the code more difficult to read for someone who isn't familiar with these concepts and tools, while also tying the type description too closely to a specific tool.
In other words, I would agree to implement them in a piece of code if and only if the simplification they provide outweighs the complexity they add.
TavoNiievez
force-pushed
the
phpstan
branch
5 times, most recently
from
aa8de78 to
ab37721
Compare
W0rma
approved these changes
Aug 3, 2025
TavoNiievez
force-pushed
the
phpstan
branch
3 times, most recently
from
bf01524 to
869ab99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.