Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeception documentation specified this is true #4

Merged
merged 1 commit into from Feb 14, 2020
Merged

Codeception documentation specified this is true #4

merged 1 commit into from Feb 14, 2020

Conversation

SaloEater
Copy link
Contributor

https://codeception.com/docs/modules/Yii2
transaction - (default: true)

@SamMousa
Copy link
Collaborator

LGTM

@SamMousa SamMousa merged commit 417a5c5 into Codeception:master Feb 14, 2020
@SamMousa
Copy link
Collaborator

Thanks!

@Naktibalda
Copy link
Member

I wonder if it had to be a documentation fix instead, this is a breaking change for some users.

#14

@SamMousa
Copy link
Collaborator

SamMousa commented Sep 8, 2020

In hindsight you are 100% right.

@SaloEater
Copy link
Contributor Author

I wonder if it had to be a documentation fix instead, this is a breaking change for some users.

#14

To be honest, if someone writes non-transactional test then he almost 100% has errors in his code.

@SamMousa
Copy link
Collaborator

SamMousa commented Sep 8, 2020

No that's not true. It might not be independent and well structured, but it is no indicator for errors...

@Naktibalda
Copy link
Member

@SamMousa It isn't too late to change default value to false and document it.

@SamMousa
Copy link
Collaborator

That's true, also fine with me.

@Naktibalda
Copy link
Member

I looked at the code and there was code which set transaction to the same value as cleanup if transaction wasn't set, and cleanup is set to true by default, so this change only made difference for users who had cleanup: false and no transaction setting in their configuration.

if ($this->config['transaction'] === null) {
$this->config['transaction'] = $this->backupConfig['transaction'] = $this->config['cleanup'];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants