Skip to content

fix: fetch the image samples for quality on effect event #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

fix: fetch the image samples for quality on effect event #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion assets/src/dashboard/parts/connected/settings/Compression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from '@wordpress/components';

import { useSelect } from '@wordpress/data';
import { useEffect } from '@wordpress/element';

/**
* Internal dependencies.
Expand All @@ -46,7 +47,6 @@ const Compression = ({
getSampleRate,
isLoading
} = select( 'optimole' );

return {
sampleImages: getSampleRate(),
isLoading: isLoading()
Expand Down Expand Up @@ -167,6 +167,13 @@ const Compression = ({
data.compression_mode = value;
setSettings( data );
};

useEffect( () => {
if ( showSample ) {
loadSample();
}
}, [ showSample ]);

return (
<>

Expand Down
17 changes: 3 additions & 14 deletions assets/src/dashboard/parts/connected/settings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import Lazyload from './Lazyload';
import Exclusions from './Exclusions';
import OffloadMedia from './OffloadMedia';
import CloudLibrary from './CloudLibrary';
import { sampleRate, saveSettings } from '../../../utils/api';
import { saveSettings } from '../../../utils/api';
import { toggleDamSidebarLink } from '../../../utils/helpers';

const Settings = ({
Expand Down Expand Up @@ -59,18 +59,7 @@ const Settings = ({
localStorage.setItem( 'optimole_settings_visits', visits ? parseInt( visits ) + 1 : 1 );
}, [ tab ]);

const loadSample = () => {
if ( ! showSample ) {
setIsSampleLoading( true );

sampleRate(
{
quality: settings.quality
},
() => setIsSampleLoading( false )
);
}

const toggleShowSample = () => {
setShowSample( ! showSample );
};

Expand Down Expand Up @@ -165,7 +154,7 @@ const Settings = ({
<Button
variant="default"
disabled={ isLoading }
onClick={ loadSample }
onClick={ toggleShowSample }
>
{ optimoleDashboardApp.strings.options_strings.view_sample_image }
</Button>
Expand Down
Loading