Part one refactor

.gitignore

@@ -1,3 +1,4 @@
 node_modules/
 dist/
 .tmp
+src/Contexts/Mooc/Courses/infrastructure/courses.*

package.json

@@ -22,6 +22,7 @@
     "@types/convict": "^4.2.1",
     "@types/errorhandler": "0.0.32",
     "@types/express": "^4.17.1",
+    "@types/glob": "^7.1.1",
     "@types/helmet": "0.0.44",
     "@types/node": "~11.13.0",
     "@types/uuid": "^3.4.5",
@@ -32,6 +33,7 @@
     "copy": "^0.3.2",
     "errorhandler": "^1.5.1",
     "express": "^4.17.1",
+    "glob": "^7.1.6",
     "helmet": "^3.21.1",
     "http-status": "^1.3.2",
     "mandrill-api": "^1.0.45",

src/Mooc/Courses/application/CreateCourse.ts → src/Contexts/Mooc/Courses/application/CourseCreator.ts

@@ -1,7 +1,7 @@
 import CourseRepository from '../domain/CourseRepository';
 import Course from '../domain/Course';
 
-export default class CreateCourse {
+export default class CourseCreator {
   private repository: CourseRepository;
 
   constructor(repository: CourseRepository) {
@@ -11,6 +11,6 @@ export default class CreateCourse {
   async run(id: string, name: string, duration: string): Promise<void> {
     const course = new Course(id, name, duration);
 
-    this.repository.save(course);
+    return this.repository.save(course);
   }
 }

src/Contexts/Mooc/Courses/domain/Course.ts

@@ -0,0 +1,11 @@
+export default class Course {
+  readonly id: string;
+  readonly name: string;
+  readonly duration: string;
+
+  constructor(id: string, name: string, duration: string) {
+    this.id = id;
+    this.name = name;
+    this.duration = duration;
+  }
+}

src/Contexts/Mooc/Courses/domain/CourseAlreadyExists.ts

@@ -0,0 +1,5 @@
+export default class CourseAlreadyExists extends Error {
+  constructor(courseId: string) {
+    super(`Course ${courseId} already exists`);
+  }
+}

src/Contexts/Mooc/Courses/domain/CourseRepository.ts

@@ -0,0 +1,8 @@
+import Course from './Course';
+import { Nullable } from '../../../Shared/domain/Nullable';
+
+export default interface CourseRepository {
+  save(course: Course): Promise<void>;
+
+  search(id: string): Promise<Nullable<Course>>;
+}

src/Contexts/Mooc/Courses/infrastructure/FileCourseRepository.ts

@@ -0,0 +1,27 @@
+import CourseRepository from '../domain/CourseRepository';
+import Course from '../domain/Course';
+import fs from 'fs';
+import BSON from 'bson';
+import { Nullable } from '../../../Shared/domain/Nullable';
+
+export default class FileCourseRepository implements CourseRepository {
+  private FILE_PATH = `${__dirname}/courses`;
+
+  async save(course: Course): Promise<void> {
+    const filePath = this.filePath(course.id);
+    const data = BSON.serialize(course);
+
+   return fs.writeFileSync(filePath, data);
+  }
+
+  async search(id: string): Promise<Nullable<Course>> {
+    const filePath = this.filePath(id);
+    const exists = fs.existsSync(filePath);
+
+    return exists ? BSON.deserialize(fs.readFileSync(this.filePath(id))) : null;
+  }
+
+  private filePath(id: string): string {
+    return `${this.FILE_PATH}.${id}.repo`;
+  }
+}

src/Contexts/Shared/domain/Nullable.ts

@@ -0,0 +1 @@
+export type Nullable<T> = T | null;

src/apps/mooc_backend/config/dependency-injection/application.yaml

@@ -1,16 +1,16 @@
 services:
   Mooc.courses.CourseRepository:
-    class: ../../../../Mooc/Courses/infrastructure/FileCourseRepository
+    class: ../../../../Contexts/Mooc/Courses/infrastructure/FileCourseRepository
     arguments: []
 
-  Mooc.courses.CreateCourse:
-    class: ../../../../Mooc/Courses/application/CreateCourse
+  Mooc.courses.CourseCreator:
+    class: ../../../../Contexts/Mooc/Courses/application/CourseCreator
     arguments: ["@Mooc.courses.CourseRepository"]
 
-  Apps.mooc.controllers.CreateCourseController:
-    class: ../../controllers/CreateCourseController
-    arguments: ["@Mooc.courses.CreateCourse"]
+  Apps.mooc.controllers.CoursePutController:
+    class: ../../controllers/CoursePutController
+    arguments: ["@Mooc.courses.CourseCreator"]
 
-  Apps.mooc.controllers.StatusController:
-    class: ../../controllers/StatusController
+  Apps.mooc.controllers.StatusGetController:
+    class: ../../controllers/StatusGetController
     arguments: []

src/apps/mooc_backend/controllers/Controller.ts

@@ -0,0 +1,5 @@
+import {Request, Response} from 'express';
+
+export default interface Controller {
+  run(req: Request, res: Response): Promise<void>;
+}

src/apps/mooc_backend/controllers/CoursePutController.ts

@@ -0,0 +1,29 @@
+import { Request, Response } from 'express';
+import CourseCreator from '../../../Contexts/Mooc/Courses/application/CourseCreator';
+import httpStatus from 'http-status';
+import Controller from './Controller';
+import CourseAlreadyExists from '../../../Contexts/Mooc/Courses/domain/CourseAlreadyExists';
+
+export default class CoursePutController implements Controller {
+  constructor(private courseCreator: CourseCreator) {}
+
+  async run(req: Request, res: Response) {
+    const id: string = req.params.id;
+    const name: string = req.body.name;
+    const duration: string = req.body.duration;
+
+    try {
+      await this.courseCreator.run(id, name, duration);
+    } catch (e) {
+
+      if (e instanceof CourseAlreadyExists) {
+        res.status(httpStatus.BAD_REQUEST).send(e.message);
+      } else {
+        res.status(httpStatus.INTERNAL_SERVER_ERROR).json(e);
+      }
+
+    }
+
+    res.status(httpStatus.CREATED).send();
+  }
+}

src/apps/mooc_backend/controllers/StatusGetController.ts

@@ -0,0 +1,9 @@
+import { Request, Response } from 'express';
+import httpStatus from 'http-status';
+import Controller from './Controller';
+
+export default class StatusGetController implements Controller {
+  async run(req: Request, res: Response) {
+    res.status(httpStatus.OK).send();
+  }
+}

src/apps/mooc_backend/routes/courses.route.ts

@@ -0,0 +1,8 @@
+import { Express } from 'express';
+import container from '../config/dependency-injection';
+import CreateCourseController from '../controllers/CoursePutController';
+
+export const register = (app: Express) => {
+  const controller: CreateCourseController = container.get('Apps.mooc.controllers.CoursePutController');
+  app.put('/courses/:id', controller.run.bind(controller));
+};

src/apps/mooc_backend/routes/index.ts

@@ -1,8 +1,12 @@
 import { Express } from 'express';
-import { statusRoute } from './status.route';
-import { createUserRoute } from './create-course.route';
+import glob from 'glob';
 
 export function registerRoutes(app: Express) {
-  statusRoute(app);
-  createUserRoute(app);
+  const routes = glob.sync(__dirname + '/**/*.route.*');
+  routes.map(route => register(route, app));
+}
+
+function register(routePath: string, app: Express) {
+    const route = require(routePath);
+    route.register(app);
 }

src/apps/mooc_backend/routes/status.route.ts

@@ -1,8 +1,8 @@
 import { Express } from 'express';
 import container from '../config/dependency-injection';
-import StatusController from '../controllers/StatusController';
+import StatusController from '../controllers/StatusGetController';
 
-export const statusRoute = (app: Express) => {
-  const controller: StatusController = container.get('Apps.mooc.controllers.StatusController');
-  app.get('/status', (req, res) => controller.create(req, res));
+export const register = (app: Express) => {
+  const controller: StatusController = container.get('Apps.mooc.controllers.StatusGetController');
+  app.get('/status', controller.run.bind(controller));
 };

tests/Mooc/Courses/application/CreateCourse.test.ts → tests/Mooc/Courses/application/CourseCreator.test.ts

@@ -1,16 +1,16 @@
-import Course from '../../../../src/Mooc/Courses/domain/Course';
-import CreateCourse from '../../../../src/Mooc/Courses/application/CreateCourse';
-import CourseRepository from '../../../../src/Mooc/Courses/domain/CourseRepository';
+import Course from '../../../../src/Contexts/Mooc/Courses/domain/Course';
+import CourseCreator from '../../../../src/Contexts/Mooc/Courses/application/CourseCreator';
+import CourseRepository from '../../../../src/Contexts/Mooc/Courses/domain/CourseRepository';
 
-describe('Create Course', () => {
+describe('Course Creator', () => {
   it('should create a valid course', async () => {
     const save = jest.fn();
     const repository: CourseRepository = {
       save,
       search: jest.fn()
     };
 
-    const createCourse = new CreateCourse(repository);
+    const createCourse = new CourseCreator(repository);
 
     const id = 'some-id';
     const name = 'some-name';

tests/Mooc/Courses/infrastructure/FileCourseRepository.test.ts

@@ -1,5 +1,5 @@
-import Course from '../../../../src/Mooc/Courses/domain/Course';
-import FileCourseRepository from '../../../../src/Mooc/Courses/infrastructure/FileCourseRepository';
+import Course from '../../../../src/Contexts/Mooc/Courses/domain/Course';
+import FileCourseRepository from '../../../../src/Contexts/Mooc/Courses/infrastructure/FileCourseRepository';
 
 describe('Save Course', () => {
   it('should have a course', () => {

tsconfig.json

@@ -7,6 +7,7 @@
     "moduleResolution": "node",
     "sourceMap": false,
     "rootDir": ".",
+    "strict": true,
     "noEmit": false,
     "resolveJsonModule": true,
     "outDir": "./dist"