Part four query bus #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com> Co-authored-by: Iván Portillo <ivanportillo@me.com>
Co-authored-by: aliondev <antonioleon@audiense.com> Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com>
Co-authored-by: aliondev <antonioleon@audiense.com> Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com>
Part four command bus
Co-authored-by: aliondev <antonioleon@audiense.com> Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com>
Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com> Co-authored-by: aliondev <antonioleon@audiense.com>
Co-authored-by: Rubén Salado <rsaladocid@users.noreply.github.com> Co-authored-by: aliondev <antonioleon@audiense.com>
JavierCane
approved these changes
Jun 25, 2020
Comment on lines
+3
to
+6
| export interface CommandHandler<T extends Command> { | ||
| subscribedTo(): Command; | ||
| handle(command: T): Promise<void>; | ||
| } |
|
|
||
| export interface CommandBus { | ||
| dispatch(command: Command): Promise<void>; | ||
| } No newline at end of file |
There was a problem hiding this comment.
What do you think about enabling the a TSLint eofline rule?
Also, we should add the tslint execution to the npm test or some other task to be executed in the project GitHub Workflow.
Do you agree? Am I missing something?
There was a problem hiding this comment.
Totally agree, I'm going to add it
Comment on lines
4
to
6
| export interface QueryBus { | ||
| ask<R extends Response>(query: Query): Promise<R>; | ||
| } No newline at end of file |
Comment on lines
+26
to
+28
| if (!queryHandler) { | ||
| throw new QueryNotRegisteredError(query); | ||
| } |
There was a problem hiding this comment.
Are we handling these exception somewhere?
There was a problem hiding this comment.
This exception and the CommandNotRegisteredError are handled by the controller, throwing a 500 error. Is not handled as a specific error but its a general error.
ivanportillo
force-pushed
the
part_four_query_bus
branch
2 times, most recently
from
8a0359a to
2e2c8c1
Compare
ivanportillo
force-pushed
the
part_four_query_bus
branch
from
2e2c8c1 to
80cb15f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.