Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread English Regular Expression tutorial #29

Closed
niccokunzmann opened this issue May 7, 2017 · 8 comments
Closed

Proofread English Regular Expression tutorial #29

niccokunzmann opened this issue May 7, 2017 · 8 comments

Comments

@niccokunzmann
Copy link
Member

niccokunzmann commented May 7, 2017

I just translated the English tutorial. There must be mistakes in the tutorial.
Please proofread and if you find somthing that you would like to see improved,

  • improve the page via the link at the bottom and submit a pull-requets.
  • or, if you do do not like to improve it straigh away, create an issue
@CodeHeeler
Copy link
Contributor

I am a first-timer and would like to do this!

@niccokunzmann
Copy link
Member Author

@CodeHeeler Welcome! Please go ahead. You can let us know here, if you need help or do not know further.

@orcutt989
Copy link
Contributor

orcutt989 commented May 10, 2017

@niccokunzmann I have some feedback having attempted to go through the tutorial in English, but if @CodeHeeler has it under control I won't worry about it.

@niccokunzmann
Copy link
Member Author

@orcutt989 I think, you can submit your feedback. It is open and collaborative. I do not think, you are taking away by giving.

@orcutt989
Copy link
Contributor

orcutt989 commented May 11, 2017

@niccokunzmann I can create an issue, but I think generally all the changes should be related to this issue, correct? Did you want an issue for each change? That sounds messy for you.

@niccokunzmann
Copy link
Member Author

@orcutt989 @CodeHeeler Thanks for your feedback. I updated the description. You can directly edit the page and submit a pull-request. I did not clearly formulate this and wondered about the new issues^^

grafik

@CodeHeeler
Copy link
Contributor

Absolutely, the more, the merrier!

Also, I apologize for misunderstanding--I was not editing the text directly here through the "improve" link, I was coding on my own branch for later, including the "Next Step" buttons and other text in the JS and CSS files that you have since changed yourself. I suppose the lesson is that when contributing, pull much more frequently. Thanks again for letting me help!

@niccokunzmann
Copy link
Member Author

Thanks for all the proof reads. Closing this, then. @orcutt989 @CodeHeeler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants