Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize worker creation logic and improved webpack handling #847

Merged
merged 1 commit into from
May 7, 2022
Merged

Centralize worker creation logic and improved webpack handling #847

merged 1 commit into from
May 7, 2022

Conversation

Danielku15
Copy link
Member

Issues

Relates to #759

Proposed changes

Move the check for a detected scriptfile so that in WebPack cases it does not need to be set.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this May 7, 2022
@Danielku15 Danielku15 merged commit 716ebb9 into develop May 7, 2022
@Danielku15 Danielku15 deleted the feature/worker-creation branch May 7, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Danielku15