Skip to content

[REFACTOR] Code refactor: second phase #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jul 19, 2021
Merged

[REFACTOR] Code refactor: second phase #22

merged 39 commits into from
Jul 19, 2021

Conversation

carlos3g
Copy link
Member

resolves #17
resolves #20

carlos3g added 30 commits July 14, 2021 21:23
@carlos3g
[REFACTOR] removes obsolete this.isSavedOrLoaded
0e136ff
@carlos3g
[REFACTOR] uses SESSION_FILE_PATH as a class attr
2abe1cb
@carlos3g
[REFACTOR] remove unnecessary try-catch block
9dd6cbf
@carlos3g
[REFACTOR] uses new keyword when invoking Error
fa75cac
@carlos3g
[REFACTOR] remove unnecessary variable assignment
dc991c8
@carlos3g
[REFACTOR] uses a better nomenclature
e850718
@carlos3g
[REFACTOR] sets .eslintrc.json.import/no-dynamic-require to 'warn'
6e138d5
@carlos3g
[REFACTOR] prevents parameter reassignment
fd84db1
@carlos3g
[REFACTOR] defines and uses Session.create method
aa2ea73
@carlos3g
[REFACTOR] remove unnecessary async keyword
83a5db0
@carlos3g
[REFACTOR] decreases number of if statements
0cd97bf
@carlos3g
[REFACTOR] defines and uses Components.has
64b427f
@carlos3g
[REFACTOR] moves REGEXP constant to inside the Content
eab7d84
@carlos3g
[REFACTOR] change Content class name to Parse
ff74dee
@carlos3g
[REFACTOR] remove future folder
8066c0f
@carlos3g
[REFACTOR] change Alice.main to Alice.onMessage
acdc1de
@carlos3g
[REFACTOR] change Parse.text to Parse.rawText
f3ec4aa
@carlos3g
[REFACTOR] change Parse.string getter to Parse.text
2b6b20f
@carlos3g
[REFACTOR] remove unnecessary comments
b5db897
@carlos3g
[REFACTOR] uses a more descriptive nomenclature for 'method' and 'com…
2a544a1 
…ponent'
@carlos3g
[FIX] uses a correct way to check if args has 'search'
be0e3db
@carlos3g
[REFACTOR] removes unnecessary else
6a57de7
@carlos3g
[REFACTOR] improves code
66403d4
@carlos3g
[REFACTOR] re-do suggest command
28c3ec6
@carlos3g
[REFACTOR] removes unused block of code
5b0c096
@carlos3g
[REFACTOR] re-do if statement
d617631
@carlos3g
[REFACTOR] re-do report command
5fbd163
@carlos3g
[REFACTOR] re-do lyric command
894c7ba
@carlos3g
[FIX] fixes wrong variable call in lyric command
09879e0
@carlos3g
[REFACTOR] update links
c4980df
@carlos3g carlos3g added Improve Improve some feature core Core related command Commands related labels Jul 19, 2021
@carlos3g carlos3g self-assigned this Jul 19, 2021
@carlos3g carlos3g merged commit 4bd6d57 into Coding-in-community:master Jul 19, 2021
@carlos3g carlos3g linked an issue Jul 20, 2021 that may be closed by this pull request
alice/future/plans.txt is unnecessary #18
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@carlos3g carlos3g

Labels

command Commands related core Core related Improve Improve some feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@carlos3g