Adds differentiation between nil and NO_VALUE #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a given key does not exist on either side we were returning nil. This makes it so we return HashDiff::NO_VALUE instead of nil if the key is not found.
|
@acuppy, this is one of our pinned repos and thought this should be fixed. 👍 It will probably need a revision bump as it will be a breaking change, maybe it can be made 1.0 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a given key does not exist on either side we were returning nil.
This makes it so we return HashDiff::NO_VALUE instead of nil if the key
is not found.
Fixes #2