Skip to content

Conversation

robchendev
Copy link
Member

@robchendev robchendev commented Oct 2, 2025

Implements #7 and #10

There are about 400 lines changed. The rest are package-lock.json reset from a dependency conflict.

Error Interceptor:

Screen.Recording.2025-10-02.at.2.10.24.PM.mov

Loading Interceptor:

Screen.Recording.2025-10-02.at.3.50.45.PM.mov

@robchendev robchendev requested a review from weijunsyu October 2, 2025 21:12
@robchendev robchendev linked an issue Oct 2, 2025 that may be closed by this pull request
* [feat] loading interceptor and service

* [feat] loading spinner in sandbox

* [feat] loading minimum delay, avoid fouc

* [cleanup] remove unused import
@robchendev robchendev changed the title [Feat] Error Interceptor [Feat] Error & Loading Interceptors Oct 2, 2025
@robchendev robchendev linked an issue Oct 2, 2025 that may be closed by this pull request

public class ApiException(int statusCode, string message, string? details)
{
public int StatusCode { get; set; } = statusCode;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should nest the exceptions incase we want to abstract the backend logic. i.e. service exception, repo exceptiion, etc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should set up the api to utilize swagger or something else for debugging

Copy link
Collaborator

@matte-o matte-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Loading Interceptor [Feat] Error Interceptor
3 participants