Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Precision DVector #583

Merged
merged 19 commits into from
Nov 10, 2017
Merged

Single Precision DVector #583

merged 19 commits into from
Nov 10, 2017

Conversation

cowchipkid
Copy link
Contributor

The DVector now stores floats, can read floats or doubles, but only writes floats.

Copy link
Contributor

@mssammon mssammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes and questions.

@@ -62,7 +62,17 @@ public SpanLabelView(String viewName, String viewGenerator, TextAnnotation text,
public void addConstituent(Constituent constituent) {
super.addConstituent(constituent);

Collections.sort(this.constituents, TextAnnotationUtilities.constituentStartComparator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth simply replacing the map with a TreeMap, as you suggest? if not now, please open an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an inherited data structure. There is already an issue open for this. I will revise the existing issue.

#
# first build cogcomp-nlp. Oddly enought, take much long to build than to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'enought'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to show I'm paying attention :-)

#
echo
echo -------- cloning code into new directories --------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this will take up a lot of space... we may want to think about how to refine it. Is it plausible to simply change output paths, or at least just create symlinks -- I'm assuming the run script launches separate processes for each parameter set; even in parallel, would this create any problems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already know how to refine this, but way out of scope for this release. This is already much smaller that it was in the previous iteration. The right way to do this is to run them all in one VM. Makes the hairs on the back of my neck rise. Much smaller memory footprint, much faster, lots less disk.

*/
public static void main1(String[] args) throws IOException {
/** get the F1 score for token only. */
String fuck = "Token-level Acc Level1:\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While guilty of the odd obscenity myself in comments, maybe rename this variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehehe. Whoops. that was a test method and should have been removed.

@danyaljj
Copy link
Member

danyaljj commented Nov 9, 2017

Looks good to me.
@mssammon ?

@mssammon
Copy link
Contributor

Good to merge and deploy.

@danyaljj danyaljj merged commit 7bd7f2f into CogComp:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants