Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the lbj version number from scripts #16

Merged
merged 5 commits into from
Jan 15, 2016
Merged

Removing the lbj version number from scripts #16

merged 5 commits into from
Jan 15, 2016

Conversation

danyaljj
Copy link
Member

removing the lbj version number from scripts, so that CI doesn't fail upon version increase

@danyaljj danyaljj changed the title WIP: removing the lbj version number from scripts Removing the lbj version number from scripts Jan 13, 2016
@christos-c
Copy link
Member

@danyaljj Can you update the illinois-core-utilities version since you're changing the script?
Also, I noticed there are two places where this dependency exist: in the pom.xml files as well as a static jar in the lib/ directory. Is there a way to unite these?

@danyaljj
Copy link
Member Author

Yeah this duplicate core-utilities is really annoying. I think this compileLBJ.sh script is really a temporary solution. I am trying to convince @mayhewsw to use his magical techniques to bypass this step with lbjava-maven-plugin.

@danyaljj
Copy link
Member Author

core-utils updated.

@christos-c
Copy link
Member

You forgot the one in the example's pom!

@danyaljj
Copy link
Member Author

done.

christos-c added a commit that referenced this pull request Jan 15, 2016
Removing the lbj version number from scripts
@christos-c christos-c merged commit fbea271 into CogComp:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants