WIP: Pairwise classifier for POS #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a bit of work and fixed some issues. The inference has some problems and I need to spend more time debugging them. |
|
where is the code? I can look at it. Specially the way you write constraints is tricky. |
|
On my fork; branch "danyaljj:pairwise-pos2". |
| } | ||
|
|
||
| def sentenceLabelsMatch = ConstrainedClassifier.constraint[Sentence] { s: Sentence => | ||
| val constituents = CommonSensors.getPOSConstituents(s.getSentenceConstituent.getTextAnnotation) |
added 4 commits
April 25, 2016 16:39
# Conflicts: # saul-core/src/main/scala/edu/illinois/cs/cogcomp/saul/classifier/ConstrainedClassifier.scala # saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/nlp/POSTagger/POSClassifiers.scala # saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/nlp/POSTagger/POSTaggerApps.scala
| // posLabelPairs._exists { case (l1, l2) => posClassifierLabelCompatible(c1, c2, l1, l2) } | ||
| // } | ||
| //constituents.toList._forall { c => posLabels._exists { l => (POSMixedClassifier on c).is(l) } } | ||
| new FirstOrderConstant(true) |
There was a problem hiding this comment.
@bhargav so I fixed the bug you pointer out but didn't help .. :-/
Another thing is I tested by replacing it with a trivial constraints new FirstOrderConstant(true) which should always be feasible; still returning a weird result ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a pairwise classifier and add a constrained classifier on top of it.
** Not carefully tested. Under construction **
FYI @bhargav