Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build a signed transaction without transmitting #21

Merged
merged 1 commit into from
Dec 11, 2016
Merged

build a signed transaction without transmitting #21

merged 1 commit into from
Dec 11, 2016

Conversation

oleiba
Copy link
Contributor

@oleiba oleiba commented Nov 30, 2016 •
edited
Loading

This PR will enable client to build a transaction (issue\send\burn) without transmitting it, thus allowing to hold the signed transaction hex, do whatever with it (e.g. store it somewhere) before transmitting it to the blockchain.
This requires passing transmit: false in the passed arguments object to issueAsset, sendAsset and burnAsset (defaults to true).

@coveralls
Copy link

coveralls commented Dec 1, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 87.809% when pulling 835b2d5 on build_tx_without_transmit into 4d72f00 on master.

tal-beja
tal-beja approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@tal-beja tal-beja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@oleiba oleiba merged commit a0fc3e3 into master Dec 11, 2016
@oleiba oleiba deleted the build_tx_without_transmit branch December 11, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tal-beja tal-beja tal-beja approved these changes

Assignees

@tal-beja tal-beja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleiba @coveralls @tal-beja