epic: export and import fit result #159
Conversation
Adds a tf file logging decorator that can be used in Optimizers to add log variables. The decorator wraps a model updating function. Co-authored-by: Remco de Boer <redeboer@gmx.com>
Co-authored-by: sjaeger <sjaeger@ep1.rub.de>
redeboer
changed the title
redeboer
changed the title
redeboer
force-pushed
the
epic/99-export-fit
branch
from
d79e2cf
to
ff31b33
Compare
* fix: only extract docs version if available * docs: describe how to start TensorBoard
* fix: remove tensorboard call * style: apply isort * feat: implement YAML optimize callback * docs: rewrite fit usage page Co-authored-by: Remco de Boer <redeboer@gmx.com>
|
I set this PR to ready for review, although #165 is still in the epic. We have to decide how urgent that issue is and whether it's the right way to go. |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 76.17% 82.88% +6.70%
==========================================
Files 12 13 +1
Lines 596 701 +105
Branches 84 96 +12
==========================================
+ Hits 454 581 +127
+ Misses 107 87 -20
+ Partials 35 33 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Speeds up CI and prevents memory problems on RTD
|
Notice that the build on RTD fails if the notebooks are run This could be because the fit is now run twice (albeit with fewer free parameters), although it doesn't seem like the runtime increased that significantly. Compare e.g. the CI for #159 Both are around 3min |
* ci: increase minimal coverage to 80% * fix: avoid deprecation warning iminuit * fix: remove pytest color output VSCode * test: add additional resonance to fixture * test: generate data in fixtures
Co-authored-by: Remco de Boer <redeboer@gmx.com>
* fix: type hint Minuit2.optimize * fix: temporary fix for #171 * refactor: change fit result dict structure * test: extract test_estimator
* fix: remove progress bar decorator * style: use alphabetical order Callback definitions * refactor: rename finalize to on_function_call_end * refactor: rename __call__ to on_iteration_end * refactor: use logs in on_iteration_end
There was a problem hiding this comment.
Good job everyone! A general remark about the tests. We have to make sure we test things a bit more thoroughly, especially also edge cases. The test we have currently just create an artificially high test coverage, which I find quite dangerous.
So we have to make some improvements on that regard. That can go into different PRs though. Possibly also good issues for @Leongrim and @sebastianJaeger to get acquaint with.
redeboer
force-pushed
the
epic/99-export-fit
branch
from
b2522bd
to
3ab70f8
Compare
redeboer
force-pushed
the
epic/99-export-fit
branch
from
2fc8bdb
to
710af47
Compare
Closes #99