Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back metadata.kernelspec to notebooks #340

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 5, 2021

Launch buttons are missing on the website since #337. This is because metadata.kernelspec was removed.

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Nov 5, 2021
@redeboer redeboer changed the title ci: upgrade pinned requirements fix: add back metadata.kernelspec to notebooks Nov 5, 2021
@redeboer redeboer self-assigned this Nov 5, 2021
@redeboer redeboer added 🐛 Bug Something isn't working 📝 Docs Improvements or additions to documentation and removed 🖱️ DX Improvements to the Developer Experience labels Nov 5, 2021
@redeboer redeboer added this to the 0.3.4 milestone Nov 5, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) November 5, 2021 14:38
@redeboer redeboer merged commit 489c875 into main Nov 5, 2021
@redeboer redeboer deleted the create-pull-request/patch-1636122563 branch November 5, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants