Skip to content

Fix column resizing in Safari #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

Fix column resizing in Safari #3752

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a636cb
Fix column resizing in Safari
amanmahajan7 Apr 7, 2025
d723848
Use `lostpointercapture`
amanmahajan7 Apr 7, 2025
cf2af41
Fix event
amanmahajan7 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions src/HeaderCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRef, useState } from 'react';
import { useState } from 'react';
import { css } from '@linaria/core';

import { useRovingTabIndex } from './hooks';
Expand Down Expand Up @@ -85,7 +85,6 @@ export default function HeaderCell<R, SR>({
direction,
dragDropKey
}: HeaderCellProps<R, SR>) {
const hasDoubleClickedRef = useRef(false);
const [isDragging, setIsDragging] = useState(false);
const [isOver, setIsOver] = useState(false);
const isRtl = direction === 'rtl';
Expand Down Expand Up @@ -120,8 +119,6 @@ export default function HeaderCell<R, SR>({
const headerCell = currentTarget.parentElement!;
const { right, left } = headerCell.getBoundingClientRect();
const offset = isRtl ? event.clientX - left : right - event.clientX;
hasDoubleClickedRef.current = false;

function onPointerMove(event: PointerEvent) {
const { width, right, left } = headerCell.getBoundingClientRect();
let newWidth = isRtl ? right + offset - event.clientX : event.clientX + offset - left;
Expand All @@ -131,24 +128,19 @@ export default function HeaderCell<R, SR>({
}
}

function onLostPointerCapture(event: PointerEvent) {
// Handle final pointer position that may have been skipped by coalesced pointer move events.
// Skip move pointer handling if the user double-clicked.
if (!hasDoubleClickedRef.current) {
onPointerMove(event);
}

function onLostPointerCapture() {
currentTarget.removeEventListener('pointermove', onPointerMove);
currentTarget.removeEventListener('lostpointercapture', onLostPointerCapture);
}

currentTarget.setPointerCapture(pointerId);
currentTarget.addEventListener('pointermove', onPointerMove);
// we are not using pointerup because it does not fire in some cases
// pointer down -> alt+tab -> pointer up over another window -> pointerup event not fired
currentTarget.addEventListener('lostpointercapture', onLostPointerCapture);
}

function onDoubleClick() {
hasDoubleClickedRef.current = true;
onColumnResize(column, 'max-content');
}

Expand Down