Rewrite some tests to reduce flakiness: part 1 #3871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3871 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 42 42
Lines 1253 1253
Branches 348 348
=======================================
Hits 1226 1226
Misses 27 27 🚀 New features to boost your workflow:
|
amanmahajan7
changed the title
amanmahajan7
commented
Sep 24, 2025
| await toggleSelection(1); | ||
| testSelection(1, false); | ||
| await testSelection(0, true); | ||
| await toggleSelection(1, false, true); // force click even if disabled |
There was a problem hiding this comment.
forcing click causes flaky test in FF.
| await page.mouse.up(); | ||
| }; | ||
|
|
||
| const scrollGrid: BrowserCommand<[{ scrollLeft?: number; scrollTop?: number }]> = async ( |
There was a problem hiding this comment.
| await userEvent.keyboard('abc'); | ||
|
|
||
| await scrollGrid({ scrollTop: 1500 }); | ||
| expect(getCellsAtRowIndex(40)[1]).toHaveTextContent(/^40$/); |
There was a problem hiding this comment.
For some reason current scrolling logic is flaky in FF
https://github.com/Comcast/react-data-grid/actions/runs/17952854675/job/51056628087
Hopefully the new commands.scrollGrid will help
amanmahajan7
commented
Sep 24, 2025
|
|
||
| await scrollGrid({ scrollTop: 1500 }); | ||
| expect(getCellsAtRowIndex(40)[1]).toHaveTextContent(/^40$/); | ||
| await userEvent.click(getCellsAtRowIndex(40)[1]); |
There was a problem hiding this comment.
This can still fail when the grid is properly scrolled. Using locators fixes it
nstepien
reviewed
Sep 26, 2025
nstepien
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vitest.dev/guide/browser/assertion-api.html#assertion-api
https://vitest.dev/guide/browser/locators.html#nth
I think we should find
cell/headercell/rowusing name instead of relying on index when possible