fix: workflow template style review #5797
Merged
+85
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 09/26/2025, 06:47:11 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
reviewed
Sep 26, 2025
Comment on lines
17
to
+22
| const baseClasses = | ||
| 'flex flex-col hover:bg-white dark-theme:hover:bg-zinc-800 rounded-lg hover:shadow-sm hover:border hover:border-zinc-200 dark-theme:hover:border-zinc-700 overflow-hidden hover:p-2' | ||
| 'cursor-pointer flex flex-col bg-white dark-theme:bg-zinc-800 rounded-lg shadow-sm border border-zinc-200 dark-theme:border-zinc-700 overflow-hidden' | ||
| if (type === 'workflow-template-card') { | ||
| return `cursor-pointer p-2 flex flex-col hover:bg-white dark-theme:hover:bg-zinc-800 rounded-lg transition-background duration-200 ease-in-out` | ||
| } |
There was a problem hiding this comment.
Suggested change
| const baseClasses = | |
| 'flex flex-col hover:bg-white dark-theme:hover:bg-zinc-800 rounded-lg hover:shadow-sm hover:border hover:border-zinc-200 dark-theme:hover:border-zinc-700 overflow-hidden hover:p-2' | |
| 'cursor-pointer flex flex-col bg-white dark-theme:bg-zinc-800 rounded-lg shadow-sm border border-zinc-200 dark-theme:border-zinc-700 overflow-hidden' | |
| if (type === 'workflow-template-card') { | |
| return `cursor-pointer p-2 flex flex-col hover:bg-white dark-theme:hover:bg-zinc-800 rounded-lg transition-background duration-200 ease-in-out` | |
| } | |
| if (type === 'workflow-template-card') { | |
| return `cursor-pointer p-2 flex flex-col hover:bg-white dark-theme:hover:bg-zinc-800 rounded-lg transition-background duration-200 ease-in-out` | |
| } | |
| const baseClasses = | |
| 'cursor-pointer flex flex-col bg-white dark-theme:bg-zinc-800 rounded-lg shadow-sm border border-zinc-200 dark-theme:border-zinc-700 overflow-hidden' | |
There was a problem hiding this comment.
I feel like the guard clause should nope out as early as possible.
There was a problem hiding this comment.
This feels like a lot of repetition, but I also think trying to abstract it away will be uglier 🫤
Comment on lines
+25
to
+28
| smallSquare: 'aspect-240/311', | ||
| square: 'aspect-256/308', | ||
| portrait: 'aspect-256/325', | ||
| tallPortrait: 'aspect-256/353', | ||
| none: '' | ||
| tallPortrait: 'aspect-256/353' |
There was a problem hiding this comment.
I don't love that neither square is actually square.
There was a problem hiding this comment.
Though in my experience, they would all go in the square hole.
| }} | ||
| </h3> | ||
| <div class="flex justify-between gap-2"> | ||
| <div class="flex-1"> |
There was a problem hiding this comment.
You might be able to get rid of this wrapper div.
Myestery
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Notion page by Unito