Skip to content

Conversation

ltitanb
Copy link
Collaborator

@ltitanb ltitanb commented Jun 26, 2024

Adds a formal Signer API spec and a simple client implementation. To clarify the naming:

  • the Signer module implements the Signer API and provides a light abstraction over different signing methods
  • Commit Modules call the Signer API to request signatures , etc

Currently the default SignerClient can be used, it expects a url endpoint and a jwt for auth, which will need to be passed by the launcher eg via ENV variables or config

@ltitanb ltitanb marked this pull request as ready for review June 26, 2024 15:35
@David-Petrov
Copy link
Contributor

David-Petrov commented Jun 27, 2024

Seems to me that the signer-api.yml and the new Signer client implementation regard a new version of the API:
cb_common::commit::client::GET_PUBKEYS_PATH = "/signer/v1/pubkeys"
cb_common::commit::client::REQUEST_SIGNATURE_PATH = "/signer/v1/request_signature"
whilst the actual HTTP service (the signer module) under cb_crypto::service::SignerService implements the old API:
cb_common::pbs::constants::PUBKEYS_PATH = "/signer/pubkeys"
cb_common::pbs::constants::SIGN_REQUEST_PATH = "/signer/sign"

Those two pairs of paths should be the same ones, shouldn't they? Or am I missing something?

Also, is the da_commit example module intentionally left unmodified?

Apart from these, everything looks good! 👍

@David-Petrov
Copy link
Contributor

LGTM 👍

@ltitanb ltitanb merged commit 4b1658b into main Jun 28, 2024
@ltitanb ltitanb deleted the signer-api branch June 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants