Skip to content

CBST-08: warn on signer load error #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

CBST-08: warn on signer load error #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/common/src/signer/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use alloy::{primitives::hex::FromHex, rpc::types::beacon::BlsPublicKey};
use eth2_keystore::Keystore;
use eyre::{eyre, Context};
use serde::{de, Deserialize, Deserializer, Serialize};
use tracing::warn;

use crate::{
config::{load_env_var, SIGNER_DIR_KEYS_ENV, SIGNER_DIR_SECRETS_ENV, SIGNER_KEYS_ENV},
Expand Down Expand Up @@ -90,11 +91,14 @@ fn load_secrets_and_keys(
let ks_path = format!("{}/{}/voting-keystore.json", keys_path, maybe_pubkey);
let pw_path = format!("{}/{}", secrets_path, pubkey);

if let Ok(signer) = load_one(ks_path, pw_path) {
signers.push(signer);
match load_one(ks_path, pw_path) {
Ok(signer) => signers.push(signer),
Err(e) => warn!("Failed to load signer for pubkey: {}, err: {}", pubkey, e),
}
} else {
warn!("Invalid pubkey: {}", maybe_pubkey);
}
};
}
}
}

Expand Down