Skip to content

Move from [u8; 32] to B256 everywhere #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

Conversation

jclapis
Copy link
Collaborator

@jclapis jclapis commented Jul 28, 2025

As requested in #329, this changes the TreeHash structs (and accompanying fields) to use B256 instead of the raw byte array type. It also does the same for domains, changing [u8; 4] to B32.

As a side-effect this cleans up some things that clippy suggested, like removing unnecessary .into() and extraneous reference operators and such.

@jclapis jclapis requested a review from ltitanb July 28, 2025 19:39
@jclapis jclapis self-assigned this Jul 28, 2025
@jclapis jclapis added the core Core part of the repo (signer, modules interface) label Jul 28, 2025
@jclapis jclapis mentioned this pull request Jul 30, 2025
@jclapis jclapis merged commit ce29c3a into prevent-cross-module-sigs Jul 30, 2025
1 check passed
@jclapis jclapis deleted the unify-b256 branch July 30, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core part of the repo (signer, modules interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants