Narrow AdvancedCollectionView trimming warning so that it only triggers in unsafe usages

components/Collections/src/AdvancedCollectionView/AdvancedCollectionView.cs

@@ -13,9 +13,6 @@ namespace CommunityToolkit.WinUI.Collections;
 /// <summary>
 /// A collection view implementation that supports filtering, sorting and incremental loading
 /// </summary>
-#if NET8_0_OR_GREATER
-[System.Diagnostics.CodeAnalysis.RequiresUnreferencedCode("Item sorting uses reflection to get property types and may not be AOT compatible.")]
-#endif
 public partial class AdvancedCollectionView : IAdvancedCollectionView, INotifyPropertyChanged, ISupportIncrementalLoading, IComparer<object>
 {
     private readonly List<object> _view;
@@ -380,6 +377,8 @@ public Predicate<object> Filter
     /// <param name="y">Object B</param>
     /// <returns>Comparison value</returns>
 #pragma warning disable CA1033 // Interface methods should be callable by child types
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Trimming", "IL2065:The method has a DynamicallyAccessedMembersAttribute (which applies to the implicit 'this' parameter), but the value used for the 'this' parameter can not be statically analyzed.", Justification = "Trimmer warnings are surfaced to the user with SortDescription")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Trimming", "IL2075:'this' argument does not satisfy 'DynamicallyAccessedMembersAttribute' in call to target method. The return value of the source method does not have matching annotations.", Justification = "Trimmer warnings are surfaced to the user with SortDescription")]
     int IComparer<object>.Compare(object x, object y)
 #pragma warning restore CA1033 // Interface methods should be callable by child types
     {

components/Collections/src/AdvancedCollectionView/SortDescription.cs

@@ -32,6 +32,7 @@ public class SortDescription
     /// </summary>
     /// <param name="direction">Direction of sort</param>
     /// <param name="comparer">Comparer to use. If null, will use default comparer</param>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code", Justification = "Not using property name")]
     public SortDescription(SortDirection direction, IComparer? comparer = null)
         : this(null!, direction, comparer!)
     {
@@ -43,6 +44,9 @@ public SortDescription(SortDirection direction, IComparer? comparer = null)
     /// <param name="propertyName">Name of property to sort on</param>
     /// <param name="direction">Direction of sort</param>
     /// <param name="comparer">Comparer to use. If null, will use default comparer</param>
+#if NET5_0_OR_GREATER
+    [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCode("Item sorting with the property name uses reflection to get the property and is not trim-safe. Either use SortDescription<T> to preserve the required metadata, or use the other constructor without a property name.")]
+#endif
     public SortDescription(string propertyName, SortDirection direction, IComparer? comparer = null)
     {
         PropertyName = propertyName;

components/Collections/src/AdvancedCollectionView/SortDescription{T}.cs

@@ -0,0 +1,30 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.Collections;
+using System.Diagnostics.CodeAnalysis;
+
+namespace CommunityToolkit.WinUI.Collections;
+
+/// <summary>
+/// A generic version of <see cref="SortDescription"/> which preserves the required metadata for reflection-based sorting.
+/// </summary>
+/// <typeparam name="T">The type to sort</typeparam>
+public class SortDescription<
+#if NET5_0_OR_GREATER
+    [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+#endif
+    T> : SortDescription
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="SortDescription{T}"/> class.
+    /// </summary>
+    /// <param name="propertyName">Name of property to sort on</param>
+    /// <param name="direction">Direction of sort</param>
+    /// <param name="comparer">Comparer to use. If null, will use default comparer</param>
+    [SuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code", Justification = "This class preserves metadata")]
+    public SortDescription(string propertyName, SortDirection direction, IComparer? comparer = null) : base(propertyName, direction, comparer)
+    {
+    }
+}