Skip to content

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Nov 15, 2021

Closes #15
Closes #41

This PR includes the following changes:

  • It changes the header in generated files to just "// "
  • It restores non-file-scoped namespaces in the generated nullability attributes, so that code builds with C# < 10

Marking as priority because without this PR, the generated attributes won't compile for users not on C# 10.

This both adds the new "// <auto-generated/>" header, as well as restores the non-file-scoped namespace declaration so that the code will compile on C# < 10 as well (which is explicitly supported by the MVVM Toolkit)
@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior improvements ✨ Improvements to an existing functionality priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Nov 15, 2021
@Sergio0694 Sergio0694 changed the title Dev/generated headers Improve header for generated files Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit priority 🚩 An issue or change that has priority
Projects
None yet
1 participant