-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ics10 cw v2 #1998
Ics10 cw v2 #1998
Conversation
Nix commands for this PRMake sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#composable-node" -L Spin up a local devnet (Dali + Rococo):nix run "github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#devnet-up" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet (Dali + Rococo + Juno):nix run "github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#devnet-xcvm-up" -L Are you on macOS, or do you not have Nix installed? No worries, you can also run these commands in Docker like this:(you only need to run the first command once on your machine) docker volume create nix
docker run --privileged --rm -v nix:/nix -v /var/run/docker.sock:/var/run/docker.sock -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#devnet-up -L --option cores 8 --extra-experimental-features nix-command --extra-experimental-features flakes" IBC Bridge# runs non configured hyperspace
nix shell --command "github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#hyperspace # runs bridge connected to parachains
nix run "github:ComposableFi/composable/9133a2f454a144e39df5d5611893955fc86f94a8#devnet-bridge Bridge is published as OSI image too. NotesNote that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
Visit the preview URL for this PR (updated for commit 9133a2f): https://picasso-f0d16--pr1998-ics10-cw-v2-326xan6v.web.app (expires Tue, 25 Oct 2022 15:22:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d4e030ec330173845b1768cd217beee9791d20f1 |
Visit the preview URL for this PR (updated for commit 9133a2f): https://pablo-afa5d--pr1998-ics10-cw-v2-wzkpzk2r.web.app (expires Tue, 25 Oct 2022 15:22:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3 |
// I do not see another way of doing it, since [`DepsMut`] isn't Eq or PartialEq | ||
impl<'a> PartialEq for Context<'a> { | ||
fn eq(&self, other: &Self) -> bool { | ||
impl<'a, H> PartialEq for Context<'a, H> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly wonder why do we need this constraint at all upstream
As part of the Cosmos Composable bridge, we're going to package our GRANDPA light client in CosmWasm. There is an ongoing effort. Once our implementation of ICS-08 is integrated in the
go-sdk
we will be able to bridge into Cosmos using our existing Rust implementations.This PR is the first of many that will wrap GRANDPA into a CW contract. For now, this one only creates a simple scaffolding structure and upgrades the dependencies between both projects (i.e.
cosmswasm-crypto
andsubstrate
->ecdsa
crate)Ref: ComposableFi/composable-ibc#61
to check: