Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBL rule: BR-CO-09 not firing #6

Closed
SiwMeckelborg opened this issue Dec 5, 2016 · 2 comments
Closed

UBL rule: BR-CO-09 not firing #6

SiwMeckelborg opened this issue Dec 5, 2016 · 2 comments
Milestone

Comments

@SiwMeckelborg
Copy link
Contributor

The rule BR-CO-09 is stating:
"The Seller VAT identifier, Seller tax representative VAT identifier, Buyer VAT identifier shall have a prefix in accordance with ISO code ISO 3166-1 alpha-2 by which the country of issue may be identified. Nevertheless, Greece may use the prefix ‘EL’. "

However, the validation rule is checking that the prefix is the same as country code for the party, I am not sure that will allways be the case. Suggest to change validation to check only that the prefix is from ISO 3166-1 alpha-2

@oriol
Copy link
Collaborator

oriol commented Dec 5, 2016

changed to not(//cac:TaxTotal///*/cbc:ID = 'VAT') or ( contains( 'AD AE AF AG AI AL AM AN AO AQ AR AS AT AU AW AX AZ BA BB BD BE BF BG BH BI BL BJ BM BN BO BR BS BT BV BW BY BZ CA CC CD CF CG CH CI CK CL CM CN CO CR CU CV CX CY CZ DE DJ DK DM DO DZ EC EE EG EH ER ES ET FI FJ FK FM FO FR GA GB GD GE GF GG GH GI GL GM GN GP GQ GR GS GT GU GW GY HK HM HN HR HT HU ID IE IL IM IN IO IQ IR IS IT JE JM JO JP KE KG KH KI KM KN KP KR KW KY KZ LA LB LC LI LK LR LS LT LU LV LY MA MC MD ME MF MG MH MK ML MM MN MO MP MQ MR MS MT MU MV MW MX MY MZ NA NC NE NF NG NI NL NO NP NR NU NZ OM PA PE PF PG PH PK PL PM PN PR PS PT PW PY QA RO RS RU RW SA SB SC SD SE SG SH SI SJ SK SL SM SN SO SR ST SV SY SZ TC TD TF TG TH TJ TK TL TM TN TO TR TT TV TW TZ UA UG UM US UY UZ VA VC VE VG VI VN VU WF WS YE YT ZA ZM ZW',substring(cbc:CompanyID,1,2) ) )

oriol added a commit that referenced this issue Dec 5, 2016
@SiwMeckelborg
Copy link
Contributor Author

Please add EL as valid code, according to rule text

oriol added a commit that referenced this issue Dec 5, 2016
@oriol oriol closed this as completed Dec 5, 2016
@phax phax added this to the v1.0 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants