Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream updates to AWS Secrets Manager change #1

Merged

Conversation

chris-j-h
Copy link

Updates include the new Tessera CLI and generic DefaultKeyVaultConfig object. Changes have been made to ensure that the AWS implementation works with these updates.

chris-j-h and others added 30 commits November 29, 2019 11:54
Create a PicoCli cmd with usage and help, and dynamically produce CLI options from config object fields
Add keygen as a subcommand to the main tessera command
Add keygen as a subcommand to the main tessera command
Add keyupdate as a subcommand to the main tessera command
# Conflicts:
#	pom.xml
This is a temporary stopgap until the cli module is flattened and further simplified
# Conflicts:
#	tessera-dist/tessera-launcher/build.gradle
Make minor changes to the pico implementation code in response to test migration
e.g. --override root.branch[1].property=overridden-value.  Previously, this was not possible.
melowe and others added 27 commits December 20, 2019 16:05
Ignore unmatchable items, log refelct exception at debug level and move on to next.
…roperties.

Add validator for key vault config that is aware of vault type and is able to apply validations for
that given type. Deprecate the Hashicorp and Azurekey vault config. Service factories use KeyVaultConfig
rather than its deprecated implementations
* Allow partyinfo to update existing key with new url. This was the behaviour before 0.10. Log message to recommend users to switch on remote key validation for better security

* Update unit test for partyinfo service
Excluding the dependency would introduce issues for users running acceptance tests with the slim jar when not also including the aws shaded jar on the classpath
The updated validation checks only that a scheme has been provided. This makes testing simpler and should be sufficient for now.
# Conflicts:
#	cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java
#	cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java
#	config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java
#	pom.xml
* Allow partyinfo to update existing key with new url. This was the behaviour before 0.10. Log message to recommend users to switch on remote key validation for better security

* Update unit test for partyinfo service

* Make partyinfo requests asynchronous

* Fix race condition in unit test

* Fix race condition in unit test

* Switch to using an executor and fix unit test
@Emi14 Emi14 merged commit 72c9880 into Emi14:feature/AWSSecretsManager Jan 8, 2020
Emi14 pushed a commit that referenced this pull request Jan 8, 2020
@chris-j-h chris-j-h deleted the AWSSecretsManager-merged branch January 22, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants