forked from Consensys/tessera
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream updates to AWS Secrets Manager change #1
Merged
Emi14
merged 68 commits into
Emi14:feature/AWSSecretsManager
from
chris-j-h:AWSSecretsManager-merged
Jan 8, 2020
Merged
Upstream updates to AWS Secrets Manager change #1
Emi14
merged 68 commits into
Emi14:feature/AWSSecretsManager
from
chris-j-h:AWSSecretsManager-merged
Jan 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a PicoCli cmd with usage and help, and dynamically produce CLI options from config object fields
Add keygen as a subcommand to the main tessera command
Add keygen as a subcommand to the main tessera command
Add keyupdate as a subcommand to the main tessera command
… and apply CLI overrides
# Conflicts: # pom.xml
This is a temporary stopgap until the cli module is flattened and further simplified
# Conflicts: # tessera-dist/tessera-launcher/build.gradle
Make minor changes to the pico implementation code in response to test migration
e.g. --override root.branch[1].property=overridden-value. Previously, this was not possible.
Ignore unmatchable items, log refelct exception at debug level and move on to next.
…roperties. Add validator for key vault config that is aware of vault type and is able to apply validations for that given type. Deprecate the Hashicorp and Azurekey vault config. Service factories use KeyVaultConfig rather than its deprecated implementations
…ain-cli Use picocli for main cli
…ult_config Generalised key vault config
* Allow partyinfo to update existing key with new url. This was the behaviour before 0.10. Log message to recommend users to switch on remote key validation for better security * Update unit test for partyinfo service
Excluding the dependency would introduce issues for users running acceptance tests with the slim jar when not also including the aws shaded jar on the classpath
The updated validation checks only that a scheme has been provided. This makes testing simpler and should be sufficient for now.
# Conflicts: # cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java # config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java # pom.xml
* Allow partyinfo to update existing key with new url. This was the behaviour before 0.10. Log message to recommend users to switch on remote key validation for better security * Update unit test for partyinfo service * Make partyinfo requests asynchronous * Fix race condition in unit test * Fix race condition in unit test * Switch to using an executor and fix unit test
…nchase/tessera into feature/AWSSecretsManager
…WSSecretsManager-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates include the new Tessera CLI and generic DefaultKeyVaultConfig object. Changes have been made to ensure that the AWS implementation works with these updates.