Generalised key vault config #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties. Add validator for key vault config that is aware of vault type and is able to apply validations for that given type. Deprecate the Hashicorp and Azurekey vault config. Service factories use KeyVaultConfig rather than its deprecated implementations
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
============================================
+ Coverage 99.28% 99.31% +0.02%
- Complexity 2050 2087 +37
============================================
Files 316 320 +4
Lines 5622 5709 +87
Branches 318 328 +10
============================================
+ Hits 5582 5670 +88
Misses 5 5
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
Krish1979
previously approved these changes
Dec 30, 2019
Krish1979
approved these changes
Dec 30, 2019
|
Resolves #959 |
This was referenced Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generalised key vault config that contains a map of generalised properties.
Add validator for key vault config that is aware of vault type and is able to apply validations for
that given type. Deprecate the Hashicorp and Azurekey vault config. Service factories use KeyVaultConfig rather than its deprecated implementations.
This provides room to add other key vaults such as the AWS one in #947.