-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow participant to anonymize their comment #181
Conversation
I | ||
className: 'fa fa-exclamation-circle' | ||
style: {paddingRight: 9} | ||
|
||
SPAN null, error | ||
|
||
if permitted > 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the change here is a trivial indentation, down to "DIV key: 'sign_checkbox'"
@@ -40,7 +40,7 @@ window.AvatarPopover = ReactiveComponent | |||
{user, anon, opinion} = @props | |||
user = fetch user | |||
|
|||
anonymous = user.key != fetch('/current_user').user && (customization('anonymize_everything') || anon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't notice any cases where I need to see my own avatar to find my own anonymous content.
- For comments, there is an edit-button by my own comments
- For reasons, there is a button to view all my own reasons
- For proposals, there is an edit-button by my own proposals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! But those don't show up after a forum has been frozen. And it is nice to be able to scan for your icon.
That said, showing the icon is problematic because people might be scared that their content was not actually posted anonymously. So I'd be in favor of removing user.key != fetch('/current_user').user from the conditional.
I believe that this pull request is superceded by #183. Does that sound accurate? |
Yes. Shall we close this pull-request? |
This change adds a "sign name" checkbox when creating/editing a comment on a reason. Anonymized comments no longer show the user name nor avatar pic.
I hid the name/photo even on the participant's own comments, since there always appears to be some other indicator of which content they entered, and showing the name/photo might confuse them about whether they successfully anonymized.
This change adds field hide_name to table comments.