Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/solomon consistent log paths #101

Merged
merged 10 commits into from
Oct 26, 2015

Conversation

SolomonShorser-OICR
Copy link
Contributor

Log to a file at ${CONSONANCE_LOG_FILE} which will be defined outside the application, instead of ./arch3.log which is relative to where ever the user is when they call an arch3/consonance command.

@@ -21,7 +21,7 @@ before_script:

script:
- mvn -B clean install -DskipITs=false
- mvn -B clean -DskipITs=false cobertura:cobertura cobertura:cobertura-integration-test coveralls:report
- mvn -B clean -DskipITs=false -DCONSONANCE_LOG_FILE=./arch3_test.log cobertura:cobertura cobertura:cobertura-integration-test coveralls:report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change the default build command here?
Does the default of test.log work for those surefire plugins?

SolomonShorser-OICR added a commit that referenced this pull request Oct 26, 2015
…g_paths

Feature/solomon consistent log paths
@SolomonShorser-OICR SolomonShorser-OICR merged commit bdc608a into develop Oct 26, 2015
@SolomonShorser-OICR SolomonShorser-OICR deleted the feature/solomon_consistent_log_paths branch October 26, 2015 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants