-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/solomon consistent log paths #101
Merged
SolomonShorser-OICR
merged 10 commits into
develop
from
feature/solomon_consistent_log_paths
Oct 26, 2015
Merged
Feature/solomon consistent log paths #101
SolomonShorser-OICR
merged 10 commits into
develop
from
feature/solomon_consistent_log_paths
Oct 26, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -21,7 +21,7 @@ before_script: | |||
|
|||
script: | |||
- mvn -B clean install -DskipITs=false | |||
- mvn -B clean -DskipITs=false cobertura:cobertura cobertura:cobertura-integration-test coveralls:report | |||
- mvn -B clean -DskipITs=false -DCONSONANCE_LOG_FILE=./arch3_test.log cobertura:cobertura cobertura:cobertura-integration-test coveralls:report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to change the default build command here?
Does the default of test.log
work for those surefire plugins?
SolomonShorser-OICR
added a commit
that referenced
this pull request
Oct 26, 2015
…g_paths Feature/solomon consistent log paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log to a file at
${CONSONANCE_LOG_FILE}
which will be defined outside the application, instead of./arch3.log
which is relative to where ever the user is when they call an arch3/consonance command.