-
Notifications
You must be signed in to change notification settings - Fork 2
Fallback to Merchandisers displayName set for recommendation pods #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to Merchandisers displayName set for recommendation pods #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just some lints. I have some ideas about improving where we do transformations, but we can follow up on that internally.
src/constants.ts
Outdated
@@ -72,7 +72,8 @@ export const sectionsDescription = `- by default, typing a query will fetch data | |||
- the order of the objects in the \`sections\` array determines the order of the results | |||
- each autocomplete section object must have a \`indexSectionName\` | |||
- each recommendation section object must have a \`podId\` | |||
- each custom section object must have a \`displayName\` | |||
- recommendation section displayName if passed will override the displayName set by Merchandisers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt of
passing displayName in the sectionConfiguration will override the displayName set by Merchandisers on the Customer Dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve
src/constants.ts
Outdated
@@ -112,6 +113,7 @@ export const zeroStateDescription = `- when the text input field has no text, we | |||
- the order of the objects in the \`zeroStateSections\` array determines the order of the results | |||
- each autocomplete section object must have a \`indexSectionName\` | |||
- each recommendation section object must have a \`podId\` | |||
- recommendation section displayName if passed will override the displayName set by Merchandisers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
src/constants.ts
Outdated
@@ -72,7 +72,8 @@ export const sectionsDescription = `- by default, typing a query will fetch data | |||
- the order of the objects in the \`sections\` array determines the order of the results | |||
- each autocomplete section object must have a \`indexSectionName\` | |||
- each recommendation section object must have a \`podId\` | |||
- each custom section object must have a \`displayName\` | |||
- recommendation section displayName if passed will override the displayName set by Merchandisers | |||
- each custom section object must have a \`displayName\`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra fullstop (.
)
Before:
After: