Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lazy streams in benchmark_with_validation_stream #677

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

lrzpellegrini
Copy link
Collaborator

This PR introduces the support for lazy streams in the benchmark_with_validation_stream helper.

That helper is used to generate a benchmark instance in which the validation stream is added by splitting the train stream. If the train stream is lazily generated, then the resulting benchmark instance will have lazily generated train and valid streams.

This behavior is fully compatible with custom splitting strategies!

This partially covers #673.

The support for lazy streams in data_incremental_benchmark will be implemented in the future as it requires a major overhaul on the Avalanche internals.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 957423453

  • 108 of 110 (98.18%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.087%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/benchmarks/scenarios/generic_cl_scenario.py 27 29 93.1%
Totals Coverage Status
Change from base Build 950073130: 0.1%
Covered Lines: 9481
Relevant Lines: 11988

💛 - Coveralls

@lrzpellegrini lrzpellegrini merged commit 09c9224 into ContinualAI:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants