Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TensorboardLogger from blocking the process exit #865

Merged
merged 4 commits into from
Dec 25, 2021

Conversation

lrzpellegrini
Copy link
Collaborator

When using __del__ as a finalizer, the TensorboardLogger could not properly free the SummaryWriter thus blocking the process exit.

The new finalization logic uses finalize (official example) to cleanup the writer object at process shutdown (or at logger garbage collection time).

Closes #864

@lrzpellegrini lrzpellegrini changed the title Prevents TensorboardLogger from blocking the process exit Prevent TensorboardLogger from blocking the process exit Dec 24, 2021
@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/logging/tensorboard_logger.py:68:81: E501 line too long (99 > 80 characters)
1       E501 line too long (99 > 80 characters)

@coveralls
Copy link

coveralls commented Dec 24, 2021

Pull Request Test Coverage Report for Build 1619418330

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.826%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/logging/tensorboard_logger.py 1 2 50.0%
Totals Coverage Status
Change from base Build 1619243472: 0.0%
Covered Lines: 11451
Relevant Lines: 14345

💛 - Coveralls

@lrzpellegrini lrzpellegrini merged commit b875547 into ContinualAI:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process doesn't close when using TensorboardLogger
3 participants