-
Notifications
You must be signed in to change notification settings - Fork 460
added tool/functions for manage_prefab and refactored manage_gameobje… #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughAdds a dedicated prefab management tool across editor and server layers. Introduces ManagePrefab.cs with a new “manage_prefab” command and routes/registry entries. Updates manage_gameobject and manage_asset to defer prefab work to the new tool. Extends Python MCP tooling to register and expose manage_prefab; adjusts docs/strings accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Client as MCP Client (Python)
participant Server as MCP Server (Python)
participant Unity as Unity Editor
participant Registry as CommandRegistry
participant Prefab as ManagePrefab
User->>Client: Call manage_prefab(action, params)
Client->>Server: register_manage_prefab_tools (startup)
Client->>Unity: send_command_with_retry("manage_prefab", params)
Unity->>Registry: GetHandler("manage_prefab")
Registry-->>Unity: ManagePrefab.HandleCommand
Unity->>Prefab: HandleCommand(params)
Prefab-->>Unity: Response { success, message, data }
Unity-->>Client: Response
Client-->>User: Result
rect rgba(230,250,230,0.6)
note right of Prefab: Actions handled<br/>- create / instantiate<br/>- open / close / save<br/>- modify / find / get_info<br/>- variant / unpack
end
sequenceDiagram
autonumber
actor User
participant Client as manage_gameobject tool
participant Unity as ManageGameObject.cs
note over Client, Unity: Prefab operations via manage_gameobject are blocked
User->>Client: Attempt prefab-related action
Client-->>User: Error: use manage_prefab
User->>Client: Use manage_prefab instead
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Flag potential breaking changes that are not documented:
1. Identify changes to public APIs/exports, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints (including removed/renamed items and changes to types, required params, return values, defaults, or behavior).
2. Ignore purely internal/private changes (e.g., code not exported from package entry points or marked internal).
3. Verify documentation exists: a "Breaking Change" section in the PR description and updates to CHANGELOG.md. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tested create prefab, modify prefab, delete prefab using Claude CLI client.
Summary by CodeRabbit
New Features
Refactor
Documentation