Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new-tool): Docker Compose to Kubernetes manifests #890

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(new-tool): Docker Compose to Kubernetes manifests #890

wants to merge 3 commits into from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Feb 18, 2024

Fix #883

@vercel Vercel
Copy link

vercel bot commented Feb 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Feb 25, 2024 1:39pm

@sharevb sharevb force-pushed the feat/docker-compose-to-kubernetes branch from e488ebd to 577b905 Compare February 18, 2024 19:35
@sharevb sharevb force-pushed the feat/docker-compose-to-kubernetes branch from 577b905 to b293763 Compare February 18, 2024 19:37
@sharevb sharevb mentioned this pull request Feb 18, 2024
Open
@TheAnachronism
Copy link

However the actual conversion takes place, there's a mistake.
The command directive in docker does something different than when used in Kubernetes.
In docker compose, the directive specifies additional arguments passed to the ENTRYPOINT of the image.
In Kubernetes, it overrides the ENTRYPOINT of the image.

args should be used instead of command.

sharevb added a commit to sharevb/docker2kube that referenced this pull request Feb 18, 2024
@sharevb
fix: docker entrypoint/command to kube command/args
2e33837 
As referred in CorentinTh/it-tools#890 (comment):
- `entrypoint` in Docker Compose is `command` in Kubernetes
- `command` in Docker Compose is `args` in Kubernetes
@sharevb sharevb mentioned this pull request Feb 18, 2024
Merged
@sharevb
Copy link
Contributor Author

sharevb commented Feb 18, 2024

Hi @TheAnachronism, made a PR in dohsimpson/docker2kube#1

@TheAnachronism
Copy link

Sick! Let's hope it gets merged soon.

@teambvd
Copy link

teambvd commented Feb 22, 2024

PR has been merged FYI

@sharevb
Copy link
Contributor Author

sharevb commented Feb 25, 2024

Hi @teambvd, docker2kube updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW TOOL] Docker command to Kubernetes kustomization
3 participants
@sharevb @TheAnachronism @teambvd