Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker entrypoint/command to kube command/args #1

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Feb 18, 2024

As referred in CorentinTh/it-tools#890 (comment) :

  • entrypoint in Docker Compose is command in Kubernetes
  • command in Docker Compose is args in Kubernetes

As referred in CorentinTh/it-tools#890 (comment):
- `entrypoint` in Docker Compose is `command` in Kubernetes
- `command` in Docker Compose is `args` in Kubernetes
@sharevb
Copy link
Contributor Author

sharevb commented Feb 18, 2024

Hi @dohsimpson, thanks for this wonderful package ! Just a little mistake as stated in https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#define-a-command-and-arguments-when-you-create-a-pod

(Actually I iniatialy made the same reverse mistake while working on composerize)

@dohsimpson
Copy link
Owner

Hi @sharevb, love your work on composerize, I use it all the time!

PR looks good, made a comment on a small semantic change. Thanks for the fix!

@sharevb
Copy link
Contributor Author

sharevb commented Feb 19, 2024

Hi @dohsimpson, thanks :) but sorry dont see where you left a comment

test/index.test.ts Outdated Show resolved Hide resolved
@dohsimpson
Copy link
Owner

Hi @dohsimpson, thanks :) but sorry dont see where you left a comment

Apologies, review was in pending state, it should be visible now

@dohsimpson dohsimpson merged commit c59175a into dohsimpson:main Feb 21, 2024
@dohsimpson
Copy link
Owner

Thank you, PR is merged!

@sharevb
Copy link
Contributor Author

sharevb commented Feb 21, 2024

Hi @dohsimpson, thanks :) could you please publish new version to npm ? thanks

@dohsimpson
Copy link
Owner

Hi @dohsimpson, thanks :) could you please publish new version to npm ? thanks

Published, please use version 0.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants